RFR: 8305902: (cs) Resolve default Charset only once in StreamEncoder and StreamDecoder [v2]

Alan Bateman alanb at openjdk.org
Wed Apr 12 16:38:59 UTC 2023


On Wed, 12 Apr 2023 12:47:22 GMT, Sergey Tsypanov <stsypanov at openjdk.org> wrote:

>> If `charsetName` passed into `forOutputStreamWriter()` method is null then `Charset.forName()` is redundant as we can use already resolved default Charset.
>
> Sergey Tsypanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Further clean-up

I looked at the callers and none of them expect null to be mapped to the default charset so I think this change is good, assuming you've run tier2.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13443#pullrequestreview-1381699299


More information about the nio-dev mailing list