RFR: 8305811: (bf) Improve performance of CharBuffer::append(CharSequence[,int,int]) [v6]
Brian Burkhalter
bpb at openjdk.org
Fri Apr 14 16:17:49 UTC 2023
On Fri, 14 Apr 2023 15:56:37 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8305811: Reorder instanceof checks
>
> src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template line 301:
>
>> 299: if (csq instanceof String str) {
>> 300: str.getChars(start, end, hb, ix(pos));
>> 301: } else if (csq instanceof StringBuilder bld) {
>
> I supposed we rename rename bld and buf to "sb" so that the naming is consistent with CharBuffer cb, heap buffer hb, etc. No big deal of course but it was sb and seems to have got renamed.
There was a little recidivism there; fixed in 72385b8c30646ad2fb2e4399c77d84f0f813f5c3.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13415#discussion_r1167034846
More information about the nio-dev
mailing list