RFR: 8305945: (zipfs) Opening a directory to get input stream produces incorrect exception message [v4]

[Lance Andersen]

On Fri, 14 Apr 2023 21:30:40 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

>> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address additional feedback
>
> test/jdk/jdk/nio/zipfs/ZipFSDirectoryExceptionMessageTest.java line 40:
> 
>> 38:  * @test
>> 39:  * @bug 8305945
>> 40:  * @summary Validate that Zip FS provides the correct exception message
> 
> This summary could perhaps be a bit more specific about which condition / message it is testing.

done

> test/jdk/jdk/nio/zipfs/ZipFSDirectoryExceptionMessageTest.java line 56:
> 
>> 54:      * Zip file to create
>> 55:      */
>> 56:     public static final String ZIP_FILE = "directoryExceptionTest.zip";
> 
> Maybe ZIP_FILE could be a Path, to avoid Path.of(ZIP_FILE) wrapping later in the test?

I often do that but chose not to when I created the test but have updated per your suggestion

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13482#discussion_r1167297960
PR Review Comment: https://git.openjdk.org/jdk/pull/13482#discussion_r1167299017