RFR: 8306374: (bf) Improve performance of DirectCharBuffer::append(CharSequence[,int,int])

Chen Liang liach at openjdk.org
Wed Apr 19 16:04:44 UTC 2023


On Wed, 19 Apr 2023 15:57:07 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> In the development of #13415 we found that those cases were not improved by the heap buffer override, but I think you are correct in that that change should also be measured before we throw it out.
>
> Changing this to also allow `String` and `StringBuffer` does not improve throughput. The reasons are that both of these use the already optimized case of putting a `String` and their `toString()` methods do not copy.

Thanks for the investigation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13522#discussion_r1171556309


More information about the nio-dev mailing list