RFR: 8306678: Replace use of os.version with an internal Version record

Roger Riggs rriggs at openjdk.org
Mon Apr 24 19:46:34 UTC 2023


On Sat, 22 Apr 2023 09:21:09 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Create an internal Version record to hold and compare versions of the form (major, minor, micro).
>> Add `OperatingSystem.version()` to return the version of the running OS.
>> Replace uses of os.version in java.base.
>> Subsequent PRs will apply to uses in other modules including, jdk.jlink, jdk.jpackage, and java.desktop.
>
> src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java line 103:
> 
>> 101:                 // fgetxattr broken on APFS prior to 10.14
>> 102:                 return OperatingSystem.version()
>> 103:                         .compareTo(new Version(10, 14)) >= 0;
> 
> The `Version(10, 14)` record should probably be stored in a static constant.

Will be removed as it is no longer needed; see PR https://github.com/openjdk/jdk/pull/13628

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13584#discussion_r1175713240


More information about the nio-dev mailing list