RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v24]

[Paul Sandoz]

On Wed, 19 Apr 2023 13:37:15 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> API changes for the FFM API (third preview)
>> 
>> ### Specdiff
>> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>> 
>> ### Javadoc
>> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/foreign/package-summary.html
>> 
>> ### Tests
>> 
>> Testing excludes tests on the "zero" platform. 
>> 
>> - [X] Tier1
>> - [X] Tier2
>> - [X] Tier3
>> - [X] Tier4
>> - [X] Tier5
>> - [X] Tier6 (Except one test applications/jcstress/init.java as per below)
>> 
>> 
>> Exception in thread "main" java.lang.IllegalStateException: /opt/mach5/mesos/work_dir/slaves/741e9afd-8c02-45c3-b2e2-9db1450d0832-S63432/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/b895db82-df34-4e71-9b59-8e23465e55c1/runs/777d38e3-4dd3-42b6-95ca-97f1167b417c/testoutput/test-support/jtreg_open_test_hotspot_jtreg_jcstress_part3/classes/2/applications/jcstress/causality/d/applications/jcstress/JcstressRunner
>> 	at org.openjdk.jcstress.util.Reflections.getClasses(Reflections.java:66)
>> 	at org.openjdk.jcstress.vm.ContendedTestMain.main(ContendedTestMain.java:43)
>> Caused by: java.lang.ClassNotFoundException: /opt/mach5/mesos/work_dir/slaves/741e9afd-8c02-45c3-b2e2-9db1450d0832-S63432/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/b895db82-df34-4e71-9b59-8e23465e55c1/runs/777d38e3-4dd3-42b6-95ca-97f1167b417c/testoutput/test-support/jtreg_open_test_hotspot_jtreg_jcstress_part3/classes/2/applications/jcstress/causality/d/applications/jcstress/JcstressRunner
>> 	at java.base/java.lang.Class.forName0(Native Method)
>> 	at java.base/java.lang.Class.forName(Class.java:497)
>> 	at java.base/java.lang.Class.forName(Class.java:476)
>> 	at org.openjdk.jcstress.util.Reflections.getClasses(Reflections.java:64)
>> 	... 1 more
>
> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 42 commits:
> 
>  - Merge branch 'master' into PR_21_V2
>  - Update test/jdk/java/foreign/TestByteBuffer.java
>    
>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>  - Merge pull request #3 from JornVernee/IsForeignLinkerSupported
>    
>    rename has_port
>  - rename has_port
>  - Merge pull request #2 from JornVernee/WSL_BB
>    
>    account for missing functional in WSL in TestByteBuffer
>  - account for missing mincore on WSL in TestByteBuffer
>  - Merge branch 'master' into PR_21_V2
>  - 8305369: Issues in zero-length memory segment javadoc section
>  - 8305087: MemoryLayout API checks should be more eager
>  - Merge master
>  - ... and 32 more: https://git.openjdk.org/jdk/compare/9fb53adf...ba04f5cc

test/micro/org/openjdk/bench/jdk/incubator/vector/TestLoadStoreBytes.java line 92:

> 90:       long byteAlignment = SPECIES.vectorByteSize();
> 91:       Arena scope = Arena.ofAuto();
> 92:       dstSegment = scope.allocate(size, byteAlignment);

Suggestion:

    srcSegment = Arena.ofAuto().allocate(size, SPECIES.vectorByteSize());
    dstSegment = Arena.ofAuto().allocate(size, SPECIES.vectorByteSize());

test/micro/org/openjdk/bench/jdk/incubator/vector/TestLoadStoreShorts.java line 97:

> 95:       long byteAlignment = SPECIES.vectorByteSize();
> 96:       Arena scope = Arena.ofAuto();
> 97:       dstSegment = scope.allocate(size, byteAlignment);

Suggestion:

    srcSegment = Arena.ofAuto().allocate(size, SPECIES.vectorByteSize());
    dstSegment = Arena.ofAuto().allocate(size, SPECIES.vectorByteSize());

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1177131218
PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1177131738