RFR: 8136895: Writer not closed with disk full error, file resource leaked [v3]

Brian Burkhalter bpb at openjdk.org
Thu Apr 27 00:37:53 UTC 2023


On Tue, 18 Apr 2023 07:21:20 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8136895: Trivial formatting corrections in tests
>
> test/jdk/java/nio/channels/Channels/Close.java line 37:
> 
>> 35: import java.nio.charset.StandardCharsets;
>> 36: 
>> 37: public class Close {
> 
> I assume we should add a test/jdk/java/io/OutputStreamWriter for this scenario too.
> 
> The Writer returned by Channels.newWriter also uses StreamEncoder so adding a test to  test/jdk/java/nio/channels/Channels/ is good too. The test is not a unit test for close, but a regression test for a specific scenario so probably should be renamed to something like CloseWriterWithFailingFlush or something like that.

Addressed in 181a943.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13503#discussion_r1178506982


More information about the nio-dev mailing list