RFR: 8313743: Make fields final in sun.nio.ch [v3]

[Andrey Turbanov]

On Fri, 4 Aug 2023 12:43:21 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> `OptionKey` is used only as a value in HashMap `sun.nio.ch.SocketOptionRegistry.LazyInitialization#options`.
>> The only usage of this map is `sun.nio.ch.SocketOptionRegistry#findOption`
>> https://github.com/openjdk/jdk/blob/e8a37b90db8dca4dc3653970b2d66d2faf8ef452/src/java.base/share/classes/sun/nio/ch/SocketOptionRegistry.java.template#L144-L147
>> Returned `OptionKey` is then only compared with `null` and then deconstructed to `level`/`name` parts.
>> 
>> Hence, changing equiality doesn't change the behavior.
>
>> Hence, changing equiality doesn't change the behavior.
> 
> We need to double check to be 100% sure, it's seems like a drive-by change that probably shouldn't be in this PR.

Ok, reverted

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14980#discussion_r1284395349