RFR: 8313743: Make fields final in sun.nio.ch [v3]

[Brian Burkhalter]

On Fri, 4 Aug 2023 13:08:04 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Found a few fields in `sun.nio.ch` package which could be declared `final`.
>> 
>> Also I took oportunity to make a couple of cleanups:
>> 1. Converted `sun.nio.ch.OptionKey` to a record. Getters naming are already match.
>> 2. Removed `sun.nio.ch.WindowsAsynchronousSocketChannelImpl#addressSize`/`sun.nio.ch.WindowsSelectorImpl#addressSize` fields. Address size is already cached inside Unsafe (since [JDK-8221477](https://bugs.openjdk.org/browse/JDK-8221477)).
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8313743: Make fields final in sun.nio.ch
>   
>   revert OptionKey back to regular class

Looks all right now. CI tier 1-3 tests succeeded on Windows-x64.

-------------

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14980#pullrequestreview-1563667580