RFR: 8020199: (fs) Files.move() throws DirectoryNotEmptyException pointing to wrong directory (win)

Brian Burkhalter bpb at openjdk.org
Wed Aug 9 16:09:30 UTC 2023


On Wed, 9 Aug 2023 14:27:44 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Amend description of when `DirectoryNotEmptyException` is thrown by `Files::move`.
>
> src/java.base/share/classes/java/nio/file/Files.java line 1414:
> 
>> 1412:      *          required to be moved and the target location is on a different
>> 1413:      *          {@code FileStore} <i>(optional specific exceptions)</i>
>> 1414:      * @throws  AtomicMoveNotSupportedException
> 
> I'm not sure about this change to the spec because there may be other reasons why entries might have to be moved, esp. when you get into exotic/custom file systems.

So do you think try to refine this or withdraw the PR and manually resolve the issue?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15199#discussion_r1288783771


More information about the nio-dev mailing list