RFR: JDK-8313873: java/net/DatagramSocket/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation [v2]
Thomas Obermeier
duke at openjdk.org
Thu Aug 10 13:30:59 UTC 2023
On Wed, 9 Aug 2023 16:25:27 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Thomas Obermeier has updated the pull request incrementally with one additional commit since the last revision:
>>
>> SendReceiveMaxSize: adjust location of constants according to comments
>
> test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java line 69:
>
>> 67: private final static int IPV4_SNDBUF = 65507;
>> 68: private final static int IPV6_SNDBUF = 65527;
>> 69: private final static int IPV6_SNDBUF_AIX = 65487;
>
> I really dislike this. I suspect the right thing will be to add a method to jdk.test.lib.net.IPSupport or some of the other test infra classes to avoid putting these constants in specific tests. Alternatively, have IPV6_SNDBUF to one of the two values to avoid adding IPV6_SNDBUF_AIX.
Hi Alan, thanks for the hints. Kindly check the latest commit.
Thomas
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15209#discussion_r1290105422
More information about the nio-dev
mailing list