RFR: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) [v2]
Tyler Steele
tsteele at openjdk.org
Fri Aug 11 23:47:29 UTC 2023
On Thu, 10 Aug 2023 19:09:53 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>>
>> - Re-Removes problem list entry
>> - Maintain linux-specific definition for minicore_vec_t
>> - Separate AIX MappedMemoryUtils to new file. Add force0 implementation
>> - Replace vm_page_size call with sysconf(_SC_PAGESIZE) in javaClasses.cpp
>
> src/java.base/aix/native/libnio/MappedMemoryUtils.c line 140:
>
>> 138: return;
>> 139: } else if (map_entry->pr_vaddr <= end_address &&
>> 140: end_address <= map_entry->pr_vaddr + map_entry->pr_size) {
>
> MappedMemoryUtils.c:140:55: error: arithmetic on a pointer to void is a GNU extension [-Werror,-Wgnu-pointer-arith]
> end_address <= map_entry->pr_vaddr + map_entry->pr_size) {
> ~~~~~~~~~~~~~~~~~~~ ^
Thanks for finding this. I am still building and testing with xlc 16.1, but it's a good idea to add 17.1 to the standard process as well. I'll fix before merging.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14964#discussion_r1291869563
More information about the nio-dev
mailing list