RFR: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) [v3]
Martin Doerr
mdoerr at openjdk.org
Mon Aug 14 18:53:20 UTC 2023
On Mon, 14 Aug 2023 16:58:06 GMT, Tyler Steele <tsteele at openjdk.org> wrote:
>> This change adds additional support to MappedByteBuffer::force which delegates to msync on AIX. Specifically, it checks whether and error with errno set to EINVAL is the cause of a msync call to an address mmapped with the MAP_PRIVATE flag set. If this flag is set, then the msync call EINVAL is expected, and can be ignored as per the Java documentation of the force method.
>>
>>> In particular, the method has no effect for buffers mapped in read-only or private mapping modes. [1]
>>
>> Separated into separate file as per recommendation by @AlanBateman.
>>
>> [1] https://download.java.net/java/early_access/jdk21/docs/api/java.base/java/nio/MappedByteBuffer.html#force()
>
> Tyler Steele has updated the pull request incrementally with one additional commit since the last revision:
>
> Cast void* to uint64_t to prevent xlc 17.1 warning
`(uint64_t)end_address <= (uint64_t)map_entry->pr_vaddr + map_entry->pr_size` works with xlc 17.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14964#issuecomment-1677889412
More information about the nio-dev
mailing list