RFR: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) [v5]

[Martin Doerr]

On Fri, 18 Aug 2023 14:49:08 GMT, Tyler Steele <tsteele at openjdk.org> wrote:

>> This change adds additional support to MappedByteBuffer::force which delegates to msync on AIX. Specifically, it checks whether and error with errno set to EINVAL is the cause of a msync call to an address mmapped with the MAP_PRIVATE flag set. If this flag is set, then the msync call EINVAL is expected, and can be ignored as per the Java documentation of the force method.
>> 
>>> In particular, the method has no effect for buffers mapped in read-only or private mapping modes. [1]
>> 
>> Separated into separate file as per recommendation by @AlanBateman.
>> 
>> [1] https://download.java.net/java/early_access/jdk21/docs/api/java.base/java/nio/MappedByteBuffer.html#force()
>
> Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into aix/TestByteBuffer-alternate
>  - Cast other void*
>  - Cast void* to uint64_t to prevent xlc 17.1 warning
>  - Re-Removes problem list entry
>  - Maintain linux-specific definition for minicore_vec_t
>  - Separate AIX MappedMemoryUtils to new file. Add force0 implementation
>  - Replace vm_page_size call with sysconf(_SC_PAGESIZE) in javaClasses.cpp
>  - Removes include unistd & replaces it with util/globalDefs.hpp
>  - Replace os::vm_page_size call with sysconf(_SC_PAGESIZE) on AIX in javaClasses.cpp

I think you need to remove "java/foreign/TestByteBuffer.java 8309475 aix-ppc64" from test/jdk/ProblemList.txt.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14964#issuecomment-1684045987