RFR: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch [v2]
Brian Burkhalter
bpb at openjdk.org
Fri Dec 1 19:40:39 UTC 2023
On Fri, 1 Dec 2023 18:44:41 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Not related to the above comments, but it looks as if the Windows registry might only be able to handle one MIME type per extension. Also, I wonder how much other software was broken by this mapping change.
>
>> It could be misleading to put a empty string into the expected set. Could the lists be created depending on the OS?
>
> I agree. I'll see what I can change.
>
>> Does WIndows 11 have a (user) way to change the mapping? For example, the mapping of .csv to vnd.ms-excel might not be correct if the user selected OpenOffice to handle .csv. I don't think we have a mechanism to cope with that.
>
> No, we don't.
> Part of me wonders if this test should be reduced to a small number of extensions, 30 seems a lot to have to keep up to date with changes like this.
I have kept them all for the time being. If a similar problem crops up in the future, however, I agree that clamping it to a smaller number of extensions might be better. The main thing is to test whether the framework functions correctly, not that every last extension yields the expected value.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16916#discussion_r1412502348
More information about the nio-dev
mailing list