RFR: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch [v2]

Brian Burkhalter bpb at openjdk.org
Mon Dec 4 17:02:38 UTC 2023


On Fri, 1 Dec 2023 19:28:26 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> If Windows 11+ is detected, add an extra expected MIME type for certain file extensions.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8320943: Change exTypes to a list and add certain EXType records conditionally on whether it is Windows 11+

test/jdk/java/nio/file/Files/probeContentType/Basic.java line 195:

> 193:             (System.getProperty("os.name").endsWith("11") ||
> 194:                 new OSVersion(10, 0).compareTo(OSVersion.current()) > 0)) {
> 195:             System.out.println("Windows 11+ detected: using different types");

I think it would be better if the Windows 11+ types were appended to the list of types here instead of replacing the types altogether.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16916#discussion_r1414209164


More information about the nio-dev mailing list