RFR: 8321429: (fc) FileChannel.lock creates a FileKey containing two long index values, they could be stored as int values [v3]

Brian Burkhalter bpb at openjdk.org
Thu Dec 7 18:14:38 UTC 2023


> The private `FileKey` fields `dwVolumeSerialNumber`, `nFileIndexHigh`, and `nFileIndexLow` are converted to `int`s to match the number of bits in their native `DWORD` counterparts. The difference in sign appears irrelevant in this case.

Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:

  8321429: Compute FileKey hash code directly instead of calling Objects.hash()

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17009/files
  - new: https://git.openjdk.org/jdk/pull/17009/files/f5cdc489..414fad62

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17009&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17009&range=01-02

  Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17009.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17009/head:pull/17009

PR: https://git.openjdk.org/jdk/pull/17009


More information about the nio-dev mailing list