RFR: 8321279: Implement hashCode() in Heap-X-Buffer.java.template [v3]
Alan Bateman
alanb at openjdk.org
Tue Dec 12 07:50:40 UTC 2023
On Fri, 8 Dec 2023 06:27:02 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8321279: Fix hashCode()
>
> Are you planning to add a microbenchmark?
> @AlanBateman added a benchmark for this. Currently I'm working on Windows and run the benchmark on Linux image on Oracle VM VirtualBox, I guess this is the reason why the improvement is not that impressive
I think the issue is that the benchmark was testing a direct ByteBuffer but the change is for heap ByteBuffer. Maybe you can re-run and paste in results?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16992#issuecomment-1851461647
More information about the nio-dev
mailing list