RFR: 8321279: Implement hashCode() in Heap-X-Buffer.java.template [v5]

Sergey Tsypanov stsypanov at openjdk.org
Tue Dec 12 20:08:32 UTC 2023


On Mon, 11 Dec 2023 11:05:52 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Sergey Tsypanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - 8321279: Add benchmark
>>  - Merge remote-tracking branch 'origin/8321279' into 8321279
>>  - Update src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template
>>    
>>    Co-authored-by: ExE Boss <3889017+ExE-Boss at users.noreply.github.com>
>>  - Update src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template
>>    
>>    Co-authored-by: ExE Boss <3889017+ExE-Boss at users.noreply.github.com>
>>  - Merge branch 'master' into 8321279
>>  - 8321279: Fix hashCode()
>>  - 8321279: Fix hashCode()
>>  - 8321279: Fix build
>>  - 8321279: Fix build
>>  - 8321279: Fix build
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/aa82b078...9a17af63
>
> test/micro/org/openjdk/bench/java/nio/ByteBuffers.java line 930:
> 
>> 928:     public int testHashCode() {
>> 929:         return directByteBuffer.hashCode();
>> 930:     }
> 
> The change is for the heap based ByteBuffer, it looks like you've added a benchmark for a direct ByteBuffer.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16992#discussion_r1424518933


More information about the nio-dev mailing list