RFR: 8293067: (fs) Implement WatchService using system library (macOS)

Michael Hall mik3hall at gmail.com
Sat Feb 4 07:40:17 UTC 2023



> On Feb 4, 2023, at 1:23 AM, Maxim Kartashev <mkartashev at openjdk.org> wrote:
> 
> On Fri, 3 Feb 2023 14:07:36 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:
> 
>>>> [JetBrains Runtime](https://github.com/JetBrains/JetBrainsRuntime) has FSEvents-based implementation of WatchService on macOS.
>>> 
>>> Is this similar to what was proposed here, I'm curious if the same issues were encountered when running the tests across a wider range of macOS releases.
>> 
>> @AlanBateman It is the implementation this one was based upon. No _known_ bugs exist there at this moment in time (tests were run on IntelliJ infrastructure, of course).
> 
>> @mkartashev Do you intend to continue work on this PR? If not, then we could potentially take over the work if that is acceptable.
> 
> I plan to have a shot at using newer (not declared deprecated) API for scheduling the event stream. If that fails, this implementation is up for grabs for all I care.
> 
> -------------
> 
> PR: https://git.openjdk.org/jdk/pull/10140

As I remember working on this was difficult because Maxim and I weren’t able to reproduce whatever errors the jdk testing framework was getting.

If you say you are done, and the PR has been closed by openjdk, I’ll grab a copy. It would probably be easier than trying to extract it from the GitHub project you posted.

How will your changes be tested if the PR has been closed?



More information about the nio-dev mailing list