RFR: 8298478: (fs) Path.of should allow input to include long path prefix [v3]

Alan Bateman alanb at openjdk.org
Tue Feb 7 18:45:26 UTC 2023


On Tue, 7 Feb 2023 18:20:10 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8298478: Address reviewer comments
>
> src/java.base/windows/classes/sun/nio/fs/WindowsPathParser.java line 164:
> 
>> 162:         }
>> 163: 
>> 164:         if (type != expectedType) {
> 
> Maybe this should also have `expectedType != null` either before of after the existing check?

Yes, `if (expectedType != null && type != expectedType)` would be clearer.

-------------

PR: https://git.openjdk.org/jdk/pull/12423


More information about the nio-dev mailing list