RFR: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed
Jaikiran Pai
jpai at openjdk.org
Tue Feb 21 07:43:30 UTC 2023
On Mon, 20 Feb 2023 18:09:44 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> This is an issue with the async close of a DatagramChannel when a thread is blocked in its adaptor's receive method and the underlying socket is non-blocking. The async close causes poll to wakeup and the underlying receive to return 0 so it can't be distinguished from a receive of a zero-length datagram. The channel state needs to be checked to distinguish the two cases so that AsynchronousCloseException can be thrown if the channel has been closed. The bug goes back to JDK 14 when caching of sockaddr structured was introduced.
>
> The test case creates the conditions to exercise the case for both the timed and untimed receive. The bug report is the timed case, which receives two datagrams before attempting a timed receive. The harder case to test is the untimed case so the test uses a virtual thread to force the underlying socket to be non-blocking.
test/jdk/java/nio/channels/DatagramChannel/AdaptorAsyncCloseAfterReceive.java line 81:
> 79: populateSocketAddressCaches(dc);
> 80:
> 81: // schedule socket to be closed while main thead blocked in receive
Trivial typo - "thead" -> "thread"
-------------
PR: https://git.openjdk.org/jdk/pull/12674
More information about the nio-dev
mailing list