RFR: 8302979: Simplify FileChannelLinesSpliterator.SUPPORTED_CHARSETS and its usage

Alan Bateman alanb at openjdk.org
Tue Feb 21 14:24:26 UTC 2023


On Tue, 21 Feb 2023 11:20:01 GMT, Sergey Tsypanov <stsypanov at openjdk.org> wrote:

> Code of `Files.lines()` could be slightly simplified:
> 
> - use charsets instead of their names
> - use `Set.of()` instead of `HashSet` in `FileChannelLinesSpliterator`

Marked as reviewed by alanb (Reviewer).

This looks okay. If cs is null then it should NPE as before. I've moved the JBS issue to the right subcomponent and adjusted the description to make it clear that this is about Files.lines.

-------------

PR: https://git.openjdk.org/jdk/pull/12688


More information about the nio-dev mailing list