Integrated: 8302603: Use Set.of in java.nio.charset.Charset

Glavo duke at openjdk.org
Tue Feb 21 17:39:39 UTC 2023


On Wed, 15 Feb 2023 09:42:53 GMT, Glavo <duke at openjdk.org> wrote:

> A small patch, using `Set.of` instead of `Collections.unmodifiableSet()` of `Charset#aliasSet`.
> 
> The alias should not be null, and the aliasSet is an immutable copy, so it is safe to use `Set.of`.
> 
> I have investigated all charsets, most of charsets have no more than 4 aliases, and the maximum is only 17.
> 
> In this case, the performance difference between immutable sets and HashSet can be ignored, and the memory footprint of immutable sets is smaller.
> 
> I need someone to help me open an Issue on JBS. Thank you very much.

This pull request has now been integrated.

Changeset: 5489c821
Author:    Glavo <zjx001202 at gmail.com>
Committer: Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5489c821dc2e0c3cfa207dc96d9183d165640368
Stats:     10 lines in 1 file changed: 0 ins; 3 del; 7 mod

8302603: Use Set.of in java.nio.charset.Charset

Reviewed-by: stsypanov, alanb, naoto

-------------

PR: https://git.openjdk.org/jdk/pull/12570


More information about the nio-dev mailing list