RFR: 8299684: (bf) JNI direct buffer functions with large capacity behave unexpectedly [v11]

Alan Bateman alanb at openjdk.org
Thu Jan 12 20:08:29 UTC 2023


On Thu, 12 Jan 2023 19:48:59 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Remove cast in `JNI::NewDirectByteBuffer`of `long` capacity to `int`, modify the constructor in question to accept a `long` capacity, and verify in the constructor that the  capacity does not overflow `int` range, throwing IAE If it does.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8299684: Remove unneeded OutOfMemoryError catch

I think this looks okay. If you are doing any further edits then the try-finally OOME can be removed from the illegalCapacities test.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11873


More information about the nio-dev mailing list