RFR: 8262742: (fs) Add Path::resolve with varargs string [v2]

Brian Burkhalter bpb at openjdk.org
Mon Jul 10 16:20:30 UTC 2023


On Sat, 8 Jul 2023 05:56:40 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 8262742: Fix typo
>>  - 8262742: Remove invalid "throws InvalidPathException"; correct typo
>
> src/java.base/share/classes/java/nio/file/Path.java line 524:
> 
>> 522:      * <p> The result of this method is the same as would be obtained
>> 523:      * by resolving the first parameter path against this path, then
>> 524:      * resovling the second parameter path against the derived path,
> 
> Typo - should have been "resolving" instead of "resovling"

Fixed in dd8c1413fc42b6b526d77c7131a10969353e0d08.

> src/java.base/share/classes/java/nio/file/Path.java line 545:
> 
>> 543:      *
>> 544:      * @throws  InvalidPathException
>> 545:      *          if the path string cannot be converted to a Path.
> 
> Is this `@throws InvalidPathException` applicable for this method, since this doesn't take any string arguments?

You are correct: that is inapplicable. Fixed in b55ade04905de70264a682404996f2f982964b01.

> src/java.base/share/classes/java/nio/file/Path.java line 567:
> 
>> 565:      * <p> The result of this method is the same as would be obtained
>> 566:      * by resolving the first parameter path string against this path, then
>> 567:      * resovling the second parameter path string against the derived path,
> 
> Typo - should have been "resolving"

Fix in b55ade04905de70264a682404996f2f982964b01. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14805#discussion_r1258492048
PR Review Comment: https://git.openjdk.org/jdk/pull/14805#discussion_r1258488611
PR Review Comment: https://git.openjdk.org/jdk/pull/14805#discussion_r1258488881


More information about the nio-dev mailing list