RFR: 8262742: (fs) Add Path::resolve with varargs string [v3]
Brian Burkhalter
bpb at openjdk.org
Wed Jul 12 17:12:09 UTC 2023
On Wed, 12 Jul 2023 11:30:41 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8262742: Verbiage cleanup
>
> src/java.base/share/classes/java/nio/file/Path.java line 520:
>
>> 518:
>> 519: /**
>> 520: * Resolves a path, or a sequence of paths against this path.
>
> I think we'll need to come up with a better first line because the method doesn't resolve the sequence of paths against this path, it instead resolves the first path against this path, then iteratively resolves.
>
> I think the second paragraph will need to include something about empty elements, as we have in the existing resolve spec.
Heavily reworked in 09704e08d6e1ba6c53bf8a7280a044c1a51e812d.
> src/java.base/share/classes/java/nio/file/Path.java line 539:
>
>> 537: * @param first the first path to resolve against this path
>> 538: *
>> 539: * @param more additional paths to be joined to form the path
>
> "additional paths to be joined to form the path" may be copied from elsewhere :-)
Blindly, even.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14805#discussion_r1261474932
PR Review Comment: https://git.openjdk.org/jdk/pull/14805#discussion_r1261473838
More information about the nio-dev
mailing list