RFR: 4860681: (bf) Add CharBuffer absolute bulk put method for CharSequence

Brian Burkhalter bpb at openjdk.org
Thu Jul 13 15:18:25 UTC 2023


On Tue, 2 May 2023 03:03:49 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Add to `java.nio.CharBuffer` an absolute bulk put method which takes a `CharSequence` as its source of `char`s.
>
> src/java.base/share/classes/java/nio/X-Buffer.java.template line 1480:
> 
>> 1478:      *     for (int i = start, j = index; i < end; i++, j++)
>> 1479:      *         dst.put(j, csq.charAt(i));
>> 1480:      * }</pre>
> 
> Suggestion:
> 
>      * {@snippet lang=java :
>      *     for (int i = start, j = index; i < end; i++, j++)
>      *         dst.put(j, csq.charAt(i));
>      * }

Good suggestion. There are however eight other occurrences of the `<pre>{@code ...}</pre>` construct already in the file and I think I would prefer to change them all under a separate issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13744#discussion_r1182742731


More information about the nio-dev mailing list