RFR: 4860681: (bf) Add CharBuffer absolute bulk put method for CharSequence [v3]

Brian Burkhalter bpb at openjdk.org
Thu Jul 13 19:28:25 UTC 2023


On Thu, 4 May 2023 07:30:52 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   4860681: Change some {@code ...} to <code>...</code> to prevent line breaking
>
> src/java.base/share/classes/java/nio/X-Buffer.java.template line 1463:
> 
>> 1461:      * that is, if
>> 1462:      * <code>end - start</code> {@code >} 
>> 1463:      * {@code limit()} - {@code index},
> 
> Suggestion:
> 
>      * <code>end - start > limit() - index</code>,

Line breaking addressed by 831cea6f7eabff6317af1ba309b2e9294b568671.

> src/java.base/share/classes/java/nio/X-Buffer.java.template line 1495:
> 
>> 1493:      * {@code IndexOutOfBoundsException} for the condition
>> 1494:      * {@code index} {@code +} {@code end} {@code -} 
>> 1495:      * {@code start} {@code >} {@code limit()}.</li>
> 
> Suggestion:
> 
>      * <code>index + end - start > limit()</code>.</li>

Line breaking addressed by 831cea6f7eabff6317af1ba309b2e9294b568671.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13744#discussion_r1262970571
PR Review Comment: https://git.openjdk.org/jdk/pull/13744#discussion_r1262970737


More information about the nio-dev mailing list