RFR: 8136895: Writer not closed with disk full error, file resource leaked [v5]

Vyom Tewari vtewari at openjdk.org
Tue Jul 18 05:48:13 UTC 2023


On Mon, 17 Jul 2023 17:52:42 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> In`StreamEncoder::implClose`, move `flushLeftoverChar()` inside the `try` block and the closing of the underlying stream inside the `finally` block.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8136895: Remove vestigial explicit calls to close() in implClose()

Code changes looks OK to me, i tested with the Test provided by original submitter and after fix i see underline file descriptors are getting closed.

-------------

Marked as reviewed by vtewari (Committer).

PR Review: https://git.openjdk.org/jdk/pull/13503#pullrequestreview-1534219343


More information about the nio-dev mailing list