RFR: 8312166: (dc) DatagramChannel's socket adaptor does not release carrier thread when blocking in receive

[Alan Bateman]

On Mon, 17 Jul 2023 10:10:20 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> DatagramChannel is "virtual thread friendly"; when configured blocking, the receive/read methods release the carrier when there is no datagram to receive.
> 
> DatagramChannel's socket adaptor (used by DatagramSocket) is not currently virtual thread friendly. The original changes proposed to address this in JDK 19 interacted with the carrier thread's buffer cache so we decided to not include them at the time. The change proposed here are to address this issue, mostly by moving the implementation of the socket adaptor's send/receive methods into the DatagramChannel implementation so that a temporary direct buffer is not held when parked.
> 
> The only observable change should be to silly/broken code that changes a DatagramPacket's buffer (with setData or setLength) while a receive is in progress. Long standing, and undocumented, behavior would for setXXX to block while a receive is in progress, new behavior will be only access the DatagramPacket's buffer when a datagram is received. I can't think of anything that could rely on behavior like this.

One thing that I noticed is that the timeout handling when a legacy SecurityManager is set (and block datagrams) is that it interferes with the receive timeout. We don't seem to have a test for that so I've added a basic test to ensure that SocketTimeoutException is thrown when there is a SM set and it blocks all datagrams.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14901#issuecomment-1641834463