RFR: 8262742: (fs) Add Path::resolve with varargs string [v8]

Brian Burkhalter bpb at openjdk.org
Thu Jul 20 03:55:08 UTC 2023


On Wed, 19 Jul 2023 15:54:23 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8262742: Further refine specifications of varargs resolve methods
>
> test/jdk/java/nio/file/Path/PathOps.java line 195:
> 
>> 193:             others[i++] = Path.of(s);
>> 194:         }
>> 195:         check(path.resolve(Path.of(first), others), expected);
> 
> This looks like it tests only the new method with Path elements.
> Are there tests for the new default method that accepts String.

Addressed in c2a8faaa1b81dbb40e1a5989a02c9e5935417358. Thanks for pointing it out.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14805#discussion_r1268901624


More information about the nio-dev mailing list