RFR: 8313368: (fc) FileChannel.size returns 0 on block special files

Alan Bateman alanb at openjdk.org
Mon Jul 31 19:13:53 UTC 2023


On Mon, 31 Jul 2023 18:16:49 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> Reinstate header files so that `BLKGETSIZE64` is defined on Linux.

src/java.base/unix/native/libnio/ch/UnixFileDispatcherImpl.c line 52:

> 50: #include <sys/ioctl.h>
> 51: #endif
> 52: 

This looks okay, I just wonder if the `#ifdef BLKGETSIZE64` could be replaced with `#ifdef __linux__` to avoid accidents when the set of include files changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15092#discussion_r1279758797


More information about the nio-dev mailing list