RFR: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
Tyler Steele
tsteele at openjdk.org
Mon Jul 31 21:31:51 UTC 2023
On Thu, 27 Jul 2023 15:10:31 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> This change adds additional support to MappedByteBuffer::force which delegates to msync on AIX. Specifically, it checks whether and error with errno set to EINVAL is the cause of a msync call to an address mmapped with the MAP_PRIVATE flag set. If this flag is set, then the msync call EINVAL is expected, and can be ignored as per the Java documentation of the force method.
>>
>>> In particular, the method has no effect for buffers mapped in read-only or private mapping modes. [1]
>>
>> Separated into separate file as per recommendation by @AlanBateman.
>>
>> [1] https://download.java.net/java/early_access/jdk21/docs/api/java.base/java/nio/MappedByteBuffer.html#force()
>
> FYI: We are excluding the failing test for the time being in #15055. The exclusion will need to be removed with the final commit for this.
Thanks for mentioning it @RealCLanger. I'll remove the exception from the ProblemList before I merge.
This PR and #14963 are ready for reviews if anyone has a chance to take a look.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14964#issuecomment-1659187510
More information about the nio-dev
mailing list