RFR: 8309778: (fs) Failed to create a symbolic link due to relative path

[Alan Bateman]

On Tue, 13 Jun 2023 03:40:53 GMT, yaqsun <duke at openjdk.org> wrote:

> Low risk, only test changes. 
> java.nio.file.NoSuchFileException: ./name1692782213124882428/link when it is a different volume/file system.
> machine info:
> 
> 文件系统       类型      容量  已用  可用 已用% 挂载点
> devtmpfs       devtmpfs  7.9G     0  7.9G    0% /dev
> tmpfs          tmpfs     7.9G  245M  7.7G    4% /dev/shm
> tmpfs          tmpfs     7.9G  893M  7.1G   12% /run
> tmpfs          tmpfs     5.0M   16K  5.0M    1% /run/lock
> tmpfs          tmpfs     7.9G     0  7.9G    0% /sys/fs/cgroup
> /dev/nvme0n1p3 xfs        42G   24G   18G   58% /
> /dev/nvme0n1p5 xfs       147G   25G  123G   17% /data
> /dev/nvme0n1p2 ext3      283M   42M  227M   16% /boot
> /dev/nvme0n1p1 vfat      300M  724K  299M    1% /boot/efi
> tmpfs          tmpfs     1.6G  160K  1.6G    1% /run/user/1001
> /dev/sda1      ext4      1.8T  913G  827G   53% /home/loongson/test-file

The CopyAndMove test will re-run the copy/move tests when the jtreg work directory is on a different file system to tmp file system. It looks like this broke at some point but may not have been noticed. I've changed the JBS issue to make it clearer what this issue is about. Do you mind renaming the PR too?

test/jdk/java/nio/file/Files/CopyAndMove.java line 65:

> 63:             // be a different volume/file system and so improve test coverage.
> 64:             String testDir = System.getProperty("test.dir", ".");
> 65:             Path dir2 = TestUtil.createTemporaryDirectory(testDir).toAbsolutePath();

This change looks okay, do you mind update the Oracle copyright header end date to 2023 too.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14436#issuecomment-1588821999
PR Review Comment: https://git.openjdk.org/jdk/pull/14436#discussion_r1227746903