RFR: 8167252: Some of Charset.availableCharsets() does not contain itself [v2]

[Jaikiran Pai]

On Wed, 14 Jun 2023 18:08:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Adding themselves into their `contains()` method will fix it.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refined the test

Marked as reviewed by jpai (Reviewer).

Hello Alan,

> > Hello Naoto, should `sun.util.PropertyResourceBundleCharset` be fixed too?
> 
> This is JDK internal, it shouldn't leak out via the APIs. If there is a way for it to leak out then it would require a compliant contains method but I suspect it's internal only.

You are right this is an internal class (I just found these by checking which classes extend `Charset`). I now paid a closer attention to the title of this issue and this is more about the Charset(s) that are returned through the public API, so I think it's OK to leave these internal classes as-is at least in this PR.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14473#pullrequestreview-1480864774
PR Comment: https://git.openjdk.org/jdk/pull/14473#issuecomment-1592498880