RFR: 8310049: Refactor Charset tests to use JUnit [v2]
Justin Lu
jlu at openjdk.org
Thu Jun 15 20:04:21 UTC 2023
> As discussed in https://github.com/openjdk/jdk/pull/14473/files, tests within _test/jdk/java/nio/charset/Charset_ could benefit from using a test framework such as JUnit.
>
> In addition, this PR groups the emptyCharset, nullCharset, and defaultCharset tests into _illegalCharsets.java_. The _default.java_ file was removed, as it did not test anything.
Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
Review: Refactoring does not require bugID in test
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14500/files
- new: https://git.openjdk.org/jdk/pull/14500/files/be352ca2..eb374d64
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14500&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14500&range=00-01
Stats: 6 lines in 6 files changed: 0 ins; 1 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/14500.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14500/head:pull/14500
PR: https://git.openjdk.org/jdk/pull/14500
More information about the nio-dev
mailing list