RFR: 8310049: Refactor Charset tests to use JUnit [v4]
Naoto Sato
naoto at openjdk.org
Fri Jun 16 17:41:03 UTC 2023
On Thu, 15 Jun 2023 23:09:24 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> As discussed in https://github.com/openjdk/jdk/pull/14473/files, tests within _test/jdk/java/nio/charset/Charset_ could benefit from using a test framework such as JUnit.
>
> Justin Lu has updated the pull request incrementally with three additional commits since the last revision:
>
> - Review: Move default test back to RegisteredCharsets.java
> - Review: rename standard charsets test
> - Revert "Remove Default test"
>
> This reverts commit 346cb4c050adb8bd8a3cb942e25a98484703b997.
test/jdk/java/nio/charset/Charset/IllegalCharsetName.java line 50:
> 48: assertThrows(IllegalArgumentException.class,
> 49: () -> Charset.forName(null));
> 50: }
Missed this one previously. This one is also not `IllegalCharsetName`, so I'd prefer not to merge this either.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14500#discussion_r1232543764
More information about the nio-dev
mailing list