RFR: 8310683: Refactor StandardCharset/standard.java to use JUnit [v4]

Justin Lu jlu at openjdk.org
Fri Jun 23 20:45:17 UTC 2023


On Fri, 23 Jun 2023 18:43:16 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge branch 'pr/14599' of https://git.openjdk.org/jdk into JUnit-StandardCharsets
>>  - Merge pr/14599
>>  - Additional cleanup
>>  - Refactor Standard.java to use JUnit + other cleanup
>>  - Fix imports and update copyright year
>
> test/jdk/java/nio/charset/StandardCharsets/Standard.java line 115:
> 
>> 113:     public void correctCharsetsTest() {
>> 114:         // Grab the value from each Standard Charset field
>> 115:         List<String> actualCharsets = Arrays.stream(StandardCharsets.class.getFields()).map(field -> {
> 
> Can `charsetFields()` be used here?

Good point, changed so that the fields are reused, and `correctCharsetsTest()` calls `charsetFields()`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14621#discussion_r1240360338


More information about the nio-dev mailing list