RFR: 8310683: Refactor StandardCharset/standard.java to use JUnit [v5]
Naoto Sato
naoto at openjdk.org
Fri Jun 23 21:07:04 UTC 2023
On Fri, 23 Jun 2023 20:45:14 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which is apart of the migration of JDK tests to JUnit. Standard.java is refactored to use JUnit, and thus split up into the following tests.
>>
>> - typeTest
>> - nameMethodTest
>> - forNameMethodTest
>> - charsetModifiersTest
>> - correctCharsetsTest
>>
>> Additionally all unused methods were removed.
>
> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
>
> - Just use charsetFields()
> - Review: reuse the standard charset fields
Marked as reviewed by naoto (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/14621#pullrequestreview-1496024461
More information about the nio-dev
mailing list