RFR: 8310902: (fc) FileChannel.transferXXX async close and interrupt issues [v2]
Alan Bateman
alanb at openjdk.org
Tue Jun 27 07:46:59 UTC 2023
On Mon, 26 Jun 2023 22:44:58 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Alan Bateman has updated the pull request incrementally with one additional commit since the last revision:
>>
>> More robustness
>
> src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 547:
>
>> 545: }
>> 546:
>> 547: // Assume at first that the underlying kernel supports sendfile();
>
> It's not just sendfile() any more so maybe this comment should be broadened.
This PR doesn't change which syscalls are used but I agree that this comment is a bit outdated, we can make it sendfile/equivalent to avoid enumerating the different syscalls and implementations that can be used.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14656#discussion_r1243280321
More information about the nio-dev
mailing list