RFR: 8310902: (fc) FileChannel.transferXXX async close and interrupt issues [v3]

Alan Bateman alanb at openjdk.org
Wed Jun 28 17:03:10 UTC 2023


On Wed, 28 Jun 2023 16:43:10 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge
>>  - Make transferFromDirect more consistent
>>  - Merge
>>  - More robustness
>>  - Update
>>  - Update
>>  - Initial commit
>
> test/jdk/java/nio/channels/FileChannel/CloseDuringTransfer.java line 194:
> 
>> 192:     @ParameterizedTest
>> 193:     @MethodSource("sources")
>> 194:     void testInterruptTransferDuringTransferFrom(ReadableByteChannel src) throws Exception {
> 
> Should this be instead `testInterruptTransferDuringTransferFrom` for consistency with `testInterruptDuringTransferTo`?

Is there a typo here, I can't quite see it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14656#discussion_r1245515990


More information about the nio-dev mailing list