RFR: 8310902: (fc) FileChannel.transferXXX async close and interrupt issues [v3]
Alan Bateman
alanb at openjdk.org
Wed Jun 28 18:37:57 UTC 2023
On Wed, 28 Jun 2023 18:07:58 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>>
>> - Merge
>> - Make transferFromDirect more consistent
>> - Merge
>> - More robustness
>> - Update
>> - Update
>> - Initial commit
>
> src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 657:
>
>> 655: long n = transferToFileDescriptor(position, count, target.fd);
>> 656: if (n == IOStatus.UNSUPPORTED_CASE) {
>> 657: transferToFileDirectNotSupported = true;
>
> On Linux, `transferToFileDescriptor` will fail with `UNSUPPORTED_CASE` if the target is open for appending. I don't think that this should mean that all future fast transfers to a file should be suppressed.
I'll check it but all I've really done here is rename fileSupported to transferToFileDirectNotSupported and inverted the values.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14656#discussion_r1245610113
More information about the nio-dev
mailing list