RFR: 8303509: Socket setTrafficClass does not work for IPv4 connections when IPv6 enabled [v2]

[Alan Bateman]

On Mon, 6 Mar 2023 16:05:07 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Update Net.shouldSetBothIPv4AndIPv6Options0 comments
>>  - Merge
>>  - Extend to SocketChannel socket adaptor
>>  - Initial commit
>
> src/java.base/share/classes/sun/nio/ch/Net.java line 104:
> 
>> 102:      * need to be set so that the settings are effective for IPv4 connections
>> 103:      * and datagrams.
>> 104:      */
> 
> There is a similar reference to multicast in the native implementations (windows and unix) of shouldSetBothIPv4AndIPv6Options0(). Maybe, the same comment change should be there too.

Good point, the comments in the native code should be aligned with the method description.

-------------

PR: https://git.openjdk.org/jdk/pull/12872