RFR: 8278268 - (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets [v19]

[Brian Burkhalter]

On Sun, 12 Mar 2023 16:31:39 GMT, Markus KARG <duke at openjdk.org> wrote:

>> This sub-issue defines the work to be done to implement JDK-8265891 solely for the particular case of FileChannel.transferFrom(ReadableByteChannel), including special treatment of SelectableByteChannel.
>
> Markus KARG has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - updated copyright
>  - Implementing 8278268
>    
>    Signed-off-by: Markus Karg <markus at headcrashing.eu>

> So can you please briefly **confirm** that I _shall not_ merge `TransferTo2` into `TransferTo` as _Lance_ proposed (hence `TransferTo2` will not be a _separate_ class anymore) but **instead** I _only shall_ abstract `testNullPointerException` and `testStreamContents` as _you_ proposed (hence keep `TransferTo2` as a _separate_ class)? Thanks.

That is fine for now. It will be possible to revisit merging at a later time if it appears reasonable.

> > ...I think the two tests `*_2GB*` should remain separate as they likely each have a sufficiently long run time.
> 
> I confirm that we had intentionally kept these two tests in separate classes due to the long run time of each, so I agree to keep them _as separate_ classes, but I will reduce _duplicate_ code.

Sounds good.

> So can you please briefly **confirm** that I am correct with this objection and the 2GB files _should not_ be renamed?

That is fine.

-------------

PR: https://git.openjdk.org/jdk/pull/6711