RFR: 8304591: UnixPath.stringValue shouldn't be volatile

Alan Bateman alanb at openjdk.org
Tue Mar 21 09:11:56 UTC 2023


On Tue, 21 Mar 2023 09:00:19 GMT, Sergey Tsypanov <stsypanov at openjdk.org> wrote:

> `UnixPath.stringValue` can be computed by multiple threads safely as the actual value is the same, so the race is benign in this case.

Can you rename this PR to align with the JBS issue?

src/java.base/unix/classes/sun/nio/fs/UnixPath.java line 48:

> 46: import static sun.nio.fs.UnixConstants.O_RDONLY;
> 47: import static sun.nio.fs.UnixNativeDispatcher.open;
> 48: import static sun.nio.fs.UnixNativeDispatcher.realpath;

Please revert this change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13115#issuecomment-1477489271
PR Review Comment: https://git.openjdk.org/jdk/pull/13115#discussion_r1143068235


More information about the nio-dev mailing list