RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v5]

[Maurizio Cimadamore]

On Tue, 21 Mar 2023 11:58:28 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> I'm not sure about this. Honestly, the example probably doesn't help much if somebody didn't get the idea of what the layout might be. I think it might be better to say something like, `on Windows/x64 the returned layout might be as follows...` and then you write the code to create the layout instance corresponding to the returned layout. But we have to be careful to make the text non-normative (as the set of values might change).
>
> What about adding something like this?
> 
> 
> Here is a list of valid names for some platforms:
>     Linux:
>         "errno"
>     macOS:
>         "errno"
>     Windows:
>         "GetLastError", "WSAGetLastError" and "errno"

I'd prefer something more informal: "Examples of valid names are "errno" on Linux/x64, or "GetLastError" on Windows/x64". And maybe add that "The precise set of platform-dependent supported names can be queried using the returned group layout".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1143272764