RFR: 8303972: Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line [v5]

[Eirik Bjorsnos]

On Thu, 23 Mar 2023 18:46:34 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add extra entry as a sanity check. Extract some constants for sizes and extract method makeOpaqueExtraField to allow some more in-depth commenting. Move extra field processing until after the LOC headers are written, such that this information only occurs in the CEN
>
> test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java line 191:
> 
>> 189:             e.setExtra(zip64);
>> 190: 
>> 191:             zo.finish(); // Write out CEN and END records
> 
> I might add one more entry after this one, perhaps with a compression method of DEFLATED

I added a third DEFLATED entry, added asserts that ZipFile and ZipFileSystem finds the expected entries. The LOC traversal no longer works, so the CEN offset is now looked up from the EOC header instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12979#discussion_r1147207105