RFR: 8202110: (fs) Default file system provider should load UnixNativeDispatcher lazily [v2]

Brian Burkhalter bpb at openjdk.org
Wed Mar 29 00:40:08 UTC 2023


On Wed, 22 Mar 2023 14:12:05 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8202110: Remove undocumented sun.nio.fs.chdirAllowed property and dependent code
>
> src/java.base/unix/classes/sun/nio/fs/UnixFileSystem.java line 123:
> 
>> 121:                 this.needToResolveAgainstDefaultDirectory = !defaultIsCwd;
>> 122:             }
>> 123:         }
> 
> Making needToResolveAgainstDefaultDirectory a tri-state is a bit ugly. If we really need to defer this then it might be better to just move the field to Holder class, that way this method would return holder.needToResolveAgainstDefaultDirectory.

The use of `needToResolveAgainstDefaultDirectory` is removed in 267f9a699410cc39fefeedd9623eae756f4e1fcd.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13132#discussion_r1151281805


More information about the nio-dev mailing list