RFR: 8286597: Implement PollerProvider on AIX
Alan Bateman
alanb at openjdk.org
Mon May 8 17:03:33 UTC 2023
On Mon, 8 May 2023 16:51:40 GMT, Tyler Steele <tsteele at openjdk.org> wrote:
>> src/java.base/share/classes/sun/nio/ch/Poller.java line 131:
>>
>>> 129: * descriptor is polled.
>>> 130: */
>>> 131: private void pollAsync(int fdVal, long nanos, BooleanSupplier supplier) {
>>
>> I don't object to renaming these private methods but "pollAsync" is confusing as the method is not asynchronous, both poll1 and poll2 are synchronous. This seems to be a drive-by change, maybe drop it from this PR as it's nothing to do with the port to AIX.
>
> It's true that the change is not related to the implementation. But, I felt it was of benefit to change the poll1 and poll2 method names to be more descriptive. Since the changes already refactor the Poller implementation, I felt it was a good time to do it.
>
> I'd be happy to change pollAsync to something that was more clear. How do you feel about `pollIndirect`?
Changing to pollIndirect is okay if you really want to change these methods.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13452#discussion_r1187674084
More information about the nio-dev
mailing list